Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Fix node icon in node creator header #9782

Merged
merged 4 commits into from
Jun 18, 2024
Merged

Conversation

elsmr
Copy link
Member

@elsmr elsmr commented Jun 17, 2024

Summary

image

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Jun 17, 2024
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️ 🎉

Copy link
Contributor

✅ No visual regressions found.

Copy link
Contributor

✅ All Cypress E2E specs passed

Copy link

cypress bot commented Jun 17, 2024

4 flaky tests on run #5536 ↗︎

0 394 0 0 Flakiness 4

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 elsmr 🗃️ e2e/*
Project: n8n Commit: b0f9fce506
Status: Passed Duration: 04:53 💡
Started: Jun 17, 2024 9:02 PM Ended: Jun 17, 2024 9:07 PM
Flakiness  5-ndv.cy.ts • 2 flaky tests

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
NDV > Stop listening for trigger event from NDV Screenshots Video
Flakiness  10-undo-redo.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Undo/Redo > should undo/redo renaming node using NDV Test Replay Screenshots Video
Flakiness  17-sharing.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Credential Usage in Cross Shared Workflows > should only show credentials from the same team project Test Replay Screenshots Video

Review all test suite changes for PR #9782 ↗︎

@elsmr elsmr merged commit b7d356f into master Jun 18, 2024
30 of 31 checks passed
@elsmr elsmr deleted the bugfix-node-mode-icon branch June 18, 2024 08:05
This was referenced Jun 20, 2024
@janober
Copy link
Member

janober commented Jun 20, 2024

Got released with [email protected]

1 similar comment
@janober
Copy link
Member

janober commented Jun 20, 2024

Got released with [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants